Holger Freyther wrote: > here we go... comments, criticism, gifts welcome
Hmm, can't say I'm bursting with joy, but at least this looks as clean as it can get, given the circumstances. Let me explain my misgivings: - the PMU callback (not your fault, I know) is questionable to me. This seems to be just the sort of thing that ought to be decided in user space. Besides, I think that the logic it implements is actually incorrect in GTA02. (Still need to prove that, though.) - callbacks from one driver into another one always bear a risk of causing nasty problems when more locking gets added for some reason. I know that there are much worse offenders, e.g., I2C, but still. - Werner
