Re: [PATCH 09/10] fix-pcf50633-migrate-gta02-peripherals-out.patch

[Holger Freyther]

On Monday 16 June 2008 00:17:54 Andy Green wrote:
> pcf50633.c shouldn't know GTAxx at all.  Move to using a
> platform callback to allow definition of platform devices
> with pcf50633 as parent device (good for enforcing suspend /
> resume ordering).  Remove all code references to GTAxx from
> the sources (one string left for compatability).

> +     /* if platform was interested, give him a chance to register
> +      * platform devices that switch power with us as the parent
> +      * at registration time -- ensures suspend / resume ordering
> +      */
> +     if (data->pdata->attach_child_devices)
> +             (data->pdata->attach_child_devices)(&new_client->dev);
> +
>       return 0;
>  exit_rtc:
>       if (data->pdata->used_features & PCF50633_FEAT_RTC)
> @@ -2268,13 +2257,6 @@ static int pcf50633_detach_client(struct i2c_client
> *client) if (pcf->pdata->used_features & PCF50633_FEAT_RTC)
>               rtc_device_unregister(pcf->rtc);
>
> -#ifdef CONFIG_MACH_NEO1973_GTA02
> -     if (machine_is_neo1973_gta02()) {
> -             platform_device_unregister(&gta01_pm_bt_dev);
> -             platform_device_unregister(&gta01_pm_gps_dev);
> -     }
> -#endif
> -

okay, we have no detach_child_devices callback but I think we will survive 
this? There are really other things broken when we fail to register the irqs.

z.