On Fri, Oct 3, 2008 at 6:33 AM, Werner Almesberger <[EMAIL PROTECTED]> wrote: > > Please don't do this. This kind of #ifdef flood is considered extremely > bad coding practice, because if makes the code hard to read and hides > subtle build issues.
I know... it was a hack to get things to build for me at all. However, it does draw attention to the fact that a lot of code is being thrown in that isn't being tested across the permutations of build options that are available. Considering that the GTA01 and the GTA02 are both our own products, it would make sense that the code builds cleanly for the four cases: i) GTA01 selected ii) GTA02 selected iii) Both iv) Neither And that's just the big picture, because there are other many option combinations, as well. Anyway, I don't mean to rant... I agree with every word you write. I just don't think it's worth ragging on this patch as it's just fixing up (poorly, I agree) what was already broken. The style issues can be fixed and I will do so at first best opportunity. Anyway, thanks Werner, for the style tutorial... it is well written. I think we should post it on the wiki. Regards, Jonas
