> > The idea is to: > > - Remove unwanted spaces > - Apply coding style fixes > - Modify strings for consistency, for instance replace "FIC Neo1073 > GTA01" with "Openmoko GTA01". > - Fix one typo > >
I don't necessarily agree with all these trivial whitespace changes. Two things bug me: i) Much of it seems pretty arbitrary (and even inconsistent)... linebreaks and braces on if-statements, in particular. ii) This makes things like git-blame impossible to use... if I want to know which patch a line came from, git-blame will now only show that it came from a whitespace-fixing patch, which is not what I was looking for (and, yes, I do use git-blame regularly... it's very useful). I know there are some style-guidelines that we need to adhere to to make upstream, but I don't see whitespace-fixing for whitespace-fixing's sake as high priority -- things are still broken in stable-tracking, let's fix that first. For now, let's just keep these whitespace patches on a separate branch and then rebase them onto our tree when the day comes that we really need them; until then, I feel that they are mostly just noise. If whitespace fixes come as a side-effect of "real" fixes, that's another story. There are other cleanups that need to be done that don't fall into the "noise" category: 1) include/asm-arm/plat-s3c and include/asm-arm/plat-s3c24xx don't belong at include/asm anymore. Find out where those files should go and move them. 2) the file drivers/mmc/host/s3cmci.c needs to be cleaned up... lots of #ifdefs, missing function definitions 3) git grep FIXME and "fix me" where applicable And a difficult one: 4) fast-charge does not work on GTA01 with 2.6.27 because bMaxPower=0ma... I've been investigating this but I'm getting nowhere... /Jonas PS: No offense, Nelson. The time you are investing in this is definitely appeciated... let's just get your time focussed on something more meaningful -- it's the best way to learn, really. Hope the above list can be of some inspiration to you...
