On Fri, Oct 17, 2008 at 06:23:27PM +0200, Simon Kagstrom wrote: > On Fri, 17 Oct 2008 11:34:53 +0200 > Harald Welte <[EMAIL PROTECTED]> wrote: > > > > echo 1 1 1 180 0 1 > wakeup > > > > Please note that there is a "single value per sysfs node" policy in > > the mainline kenrel, so this will unlikely get merged. > > > > I understand what you're trying to do, and it makes a lot of sense to > > have this 'atomic' in one sysfs write. But still, the abovementioned > > policy is there... > > OK. Well, I'll cook up a new patch someday then. However, the interface > won't be pretty if we supply multiple files for this. > > Perhaps it's OK to allow only setting of e.g., the threshold value and > let the others be "implicit", i.e., less configurability but leaner > interface. Or alternatively put everything in a hex value.
I don't see anything wrong with first writing to the threshold, etc. values and then after all values are set you enable it by writing '1' to the x, y or z files. If there is a problam updating the threshold after the wakeup setting is active, you can also reject sysfs writes depending on which overall state you are in. -- - Harald Welte <[EMAIL PROTECTED]> http://openmoko.org/ ============================================================================ Software for the world's first truly open Free Software mobile phone
