-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Somebody in the thread at some point said: | Hi, | | | Here's a pcf50633 driver rewrite to use the MFD model. This has resulted | in pretty large number of changes.
Some warnings came out: drivers/mfd/pcf50633-core.c:119: warning: initialization from incompatible pointer type drivers/mfd/pcf50633-core.c: In function ‘pcf50633_suspend’: drivers/mfd/pcf50633-core.c:266: warning: unused variable ‘ret’ drivers/mfd/pcf50633-mbc.c:88: warning: initialization from incompatible pointer type | 4. Emergency 8s shutdown has been temporarily removed from the driver | as it certainly does not belong there. On pcf50606 this was a hardware feature: it is on pcf50633 too but it's disabled on our variant. So it is arguable that reproducing it belongs in the driver. | 5. 'Suppress onkey events on resume' - must be a better way to handle | this. Can't it be done from userspace ? Dunno where the issue comes that it suppresses the notifcation for, if it is opowerd controlled it should know it is coming from wake. | 6. Resume reason - Removed currenty. More discussion required on format | of sysfs attribute. We have to capture the first resume interrupt source bytes in this driver because they don't exist anywhere else. They're currently exposed into sysfs elsewhere, but that can be done here too and make the resume reason parsing in two parts. - -Andy -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org iEYEARECAAYFAkkgiOkACgkQOjLpvpq7dMq6uACfUI00qJvdG5O3ScoWkT523sEz BVUAn3M1rR3t6xEwmTdcTVG9Lqsn+uFp =C90+ -----END PGP SIGNATURE-----
