Andy Green wrote:
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Somebody in the thread at some point said:
| Hi,
|>
|> I actually have everything patched correctly here with the exception
|> of the drivers going into drivers/misc directly, but Michael seems to
|> be showing good initiative in getting things into the kernel. It would
|> be great if it could be done correctly, however, and placed in the
|> appropriate place. i.e. kernel/power and either drivers/misc or
|> drivers/staging/misc.
| Well, I have a running android freerunner too with this patchset. So I
| know how these drivers work,
| I have done some fixes for the freerunner too, and my suspend/resume
| works corrently in my release.
| You can download the image from my web site or just recompile the
kernel
| and use my rootfs. Well I'm sorry
| that you are not so happy.
If I understood it Sean's just saying they should be in
staging/drivers/misc, and that they patchset meddles in printk.c.
We're not driving upstream for this patchset Google is AFAIK, we just
have to try to absorb what's being changed. At the moment there is a
staging/drivers/android in our tree so it's OK if we put it there today.
~ But next rebase we may have to move it again, I guess it's not a huge
problem then.
printk.c stuff is a bit messy for us to carry alone but it's OK.
So I took the patches -- thanks for your work on it -- but we will need
another round of moving / cleaning up next rebase to upstream it seems.
Yes, indeed. That is all I'm saying. Your patches are appreciated.
Thanks,
Sean