-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Somebody in the thread at some point said: | On Sat, Feb 21, 2009 at 11:29:20PM +0800, Andy Green wrote: | |> Well we will need to figure out what was broken in the meanwhile then, |> but at that time it was definitely broken. | | You were trying to do it without any cooperation from the rest of the | kernel which made everything racy IIRC.
Well, "I" did not write any of that existing code, I just run around trying to keep it working on rebases and this area changed. I referred to other implementations in the Alsa SoC tree to try to see what was expected, but I was unable to get it to work without doing what we do now. Since I don't have the luxury of dealing with just one domain blowing chunks, that was and has been good enough. But I noticed wm8753 gta02 implementation has always done registration stuff in its driver init function more commonly done in the device end which is going to be racy, but as I say that's not my code. If you want to change this to "do it [with] cooperation from the rest of the kernel" please feel free to improve it and I'll be interested to see how it should be done. - -Andy -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org iEYEARECAAYFAkmglSoACgkQOjLpvpq7dMru/gCfRErqFQsOnRS0+r56RkUfPiQV CqYAn3PmzBHDh5p1IvAKUs+j2ZBr/DFb =m4zB -----END PGP SIGNATURE-----
