Luca Capello wrote:
Hi there!
One of the kernel builds for Debian (on a QNAP TS-409U) failed with an
error with the attached config and the following compilation commands:

  $ yes "" | $(MAKE) ARCH=arm oldconfig
  $ $(MAKE) ARCH=arm EXTRAVERSION=-SOMEDEBIANVERSION

=====
  CC      arch/arm/mach-s3c2440/dma.o
arch/arm/mach-s3c2410/include/mach/dma.h:201: warning: 's3c_dma_has_circular' 
defined but not used
  CC      arch/arm/mach-s3c2440/mach-smdk2440.o
  LD      arch/arm/mach-s3c2440/built-in.o
  CC      arch/arm/mach-s3c2442/s3c2442.o
  CC      arch/arm/mach-s3c2442/clock.o
  CC      arch/arm/mach-s3c2442/mach-gta02.o
arch/arm/mach-s3c2442/mach-gta02.c:706: error: 'gta02_pmu_force_shutdown' 
undeclared here (not in a function)
make[2]: *** [arch/arm/mach-s3c2442/mach-gta02.o] Error 1
make[1]: *** [arch/arm/mach-s3c2442] Error 2
make[1]: Leaving directory `/tmp/buildd/linux-2.6-openmoko-20090702.gitd1c828aa'
make: *** [build-stamp] Error 2
=====

Is this a real (and known) issue or am I fault somewhere?

Thx, bye,
Gismo / Luca
Hi

gta02_pmu_force_shutdown is only defined when CONFIG_CHARGER_PCF50633 is set, but it's used unconditionall. I attached a simple patch, which fixes the build issue.
But I guess you want to define CHARGER_PCF50633 anyway.

- Lars
diff --git a/arch/arm/mach-s3c2442/mach-gta02.c b/arch/arm/mach-s3c2442/mach-gta02.c
index cb821ce..82b7de8 100644
--- a/arch/arm/mach-s3c2442/mach-gta02.c
+++ b/arch/arm/mach-s3c2442/mach-gta02.c
@@ -490,6 +490,7 @@ static int gta02_udc_vbus_status(void)
 #define gta02_get_charger_online_status NULL
 #define gta02_get_charger_active_status NULL
 #define gta02_pmu_event_callback        NULL
+#define gta02_pmu_force_shutdown        NULL
 #define gta02_udc_vbus_draw             NULL
 #define gta02_udc_vbus_status           NULL
 #endif

Reply via email to