Everyone, The Dictionary tests are pointing to some possible issues:
(a) The Set<StringList> class being returned from asStringSet() has defined an iterator(), contains(). and size() methods. The tests seem to suggest that the hashCode() values for the two sets need to be identical. Unfortunately, this is not the case because of the implementation. The hashCode() and equals() methods would need to be written for this to be fixed. Currently, the hashCode() for the iterated members should be correct... however, the Set's hashCode() function isn't getting the same results due to the method of calculating the hashCode().
(b) I've added locally some more tests to the dictionary; but, I'd like to run it past everyone before attempting to make changes. I'll post as separate messages with explanations, if that is okay.
(c) Okay, maybe this one is a bit bothersome to some. The IDE I'm using is showing items that should have an @Override tag to indicate the functions are overriding super class items of the same name. I'm not sure if this is something we need to migrate to the correct style or we should leave them as advertized (as is)?
(d) I'm also not sure on the inheritance part for Java. I'm thinking also that the StringListWrapper may be better suited to be a class that 'extends StringList' instead of just wrapping? Any ideas or thought on this?
-James
