On 11/7/11 10:45 AM, Aliaksandr Autayeu wrote:
I agree about discussion and let me explain. They are various
annoying compilation and build warnings and missing Javadocs. They are
faster to fix right away while you're at it and forget rather than
copy\paste messages from console to mailing list and discuss. For example,
[WARNING]
\OpenNLP\1.5.1\apache-opennlp-1.5.1-incubating-src\opennlp-maxent\src\main\java\opennlp\maxent\io\ObjectGISModelReader.java:38:
warning - @param argument "dis" is not a parameter name.
and 56 other similar ones. I might be willing to fix them while I'm working
on the project and might be willing to send a pull request or make a
commit, but copy-pasting such things to bug tracker, making patches,
copy-pasting emails... The barrier to entry becomes just a little to high
for a small nuisances. It's very similar with the console tool, although
it's a little more worthy of extra effort.
I think he was more concerned about bugs or some bigger problems you
noticed.
Help with fixing the javadoc warnings is really appreciated, and there
is no need
to discuss every single fix. We will review your patch and if something
comes up during the review we give appropriate feedback.
Please open a jira issue where you explain that javadoc warnings are
fixed, and then
provide a patch which fixes them.
Thanks,
Jörn
