Thank you for feedback. I did that.
> This would be nice. I wonder if the impact is that big, because > many loops deal with multiple arrays and need an index. > Take a look yourself. Overall there were about 120 instances. And by the way, I have found some code which looks a bit strange, but I'm filing that as a different question. If you create a bigger patch maybe split it between the maxent > and tools package. > Done. https://issues.apache.org/jira/browse/OPENNLP-368 https://issues.apache.org/jira/browse/OPENNLP-369 > Do you now use git? Yes, after they have fixed initial out-of-sync, now I mainly use git mirror. However, I keep also svn and check that mirror is ok. And also keep git-svn to avoid throwing away all that synchronization I did while waiting for INFRA to do their job. Aliaksandr > On 11/9/11 10:30 AM, Aliaksandr Autayeu wrote: > >> Dear all, >> >> I would like to ask your opinion: what do you think about "for-each" loops >> and old-style indexed loops. In my projects I have found that for-each >> loops have several advantages: >> >> 1) code readability - code is easier to read >> 2) less code - and fewer possibilities for mistakes >> 3) eases refactorings - one have to change less code during future changes >> >> There are many instances in OpenNLP where new style, shorter and cleaner >> loops can be used. I might provide a patch. What do you think? >> >> Aliaksandr >> >> >
