[ 
https://issues.apache.org/jira/browse/OPENNLP-363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13146587#comment-13146587
 ] 

Joern Kottmann commented on OPENNLP-363:
----------------------------------------

The "outcome" arrays are usually very small (3 to 50 elements) and I therefore 
wonder if the usage of system copy wouldn't slow things done.
There are also cases where we copy large arrays via a loop (e.g. 
PerceptronModelWriter), I guess that would make sense to replace the call there.

Anyway we would need to do performance measuring on some test data, to ensure 
we don't get a performance regression.
                
> performance-issues: manual array or collection copy,  appending strings, 
> string creation, extra .toString()
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: OPENNLP-363
>                 URL: https://issues.apache.org/jira/browse/OPENNLP-363
>             Project: OpenNLP
>          Issue Type: Improvement
>    Affects Versions: tools-1.5.3-incubating, maxent-3.0.3-incubating
>            Reporter: Aliaksandr Autayeu
>            Priority: Minor
>              Labels: patch
>         Attachments: 
> 0003-performance-issues-manual-array-or-collection-copy-a.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> There are multiple performance nuisances: manual array or collection copy, 
> appending strings, string creation, extra .toString() calls.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to