[
https://issues.apache.org/jira/browse/OPENNLP-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13148436#comment-13148436
]
Joern Kottmann commented on OPENNLP-369:
----------------------------------------
Mostly applied the patch with a few exceptions.
- No need to enhance code which will be removed any way
- In one case there was a nested for loop, but only the outer loop was updated,
I kept the old version, should be either two nested for each loops or two
nested for loops
- One loop was a bit confusing because of already bad variable naming, should
be re-factored to have better variables names and a for each loop (was in one
of the Indxer classes)
> loops improved in maxent
> ------------------------
>
> Key: OPENNLP-369
> URL: https://issues.apache.org/jira/browse/OPENNLP-369
> Project: OpenNLP
> Issue Type: Improvement
> Components: Maxent
> Affects Versions: maxent-3.0.3-incubating
> Reporter: Aliaksandr Autayeu
> Priority: Minor
> Labels: patch
> Attachments: 0009-loops-improved-in-maxent.patch
>
>
> Many old-style indexed loops where refactored to new Java5 loopsto improve
> code readability.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
