[
https://issues.apache.org/jira/browse/OPENNLP-428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205290#comment-13205290
]
Joern Kottmann commented on OPENNLP-428:
----------------------------------------
Please try to follow our code conventions. We are always using two spaces to
indent, an never 4 spaces or a tab.
There should be spaces around operators e.g. 1 + 1 and not 1+1.
More information can be found here:
http://incubator.apache.org/opennlp/code-conventions.html
I usually review the patch file itself or the commit mails. This patch removes
and adds CmdLineTool.
Does someone know why this happens? The CmdLineTool class has the eol-style
property set to native,
so that should be fine.
We also need support to pass in the eos chars via the cmd line trainer.
> make EOS character set configurable
> -----------------------------------
>
> Key: OPENNLP-428
> URL: https://issues.apache.org/jira/browse/OPENNLP-428
> Project: OpenNLP
> Issue Type: Improvement
> Components: Sentence Detector
> Reporter: Katrin Tomanek
> Priority: Minor
> Fix For: tools-1.5.3-incubating
>
> Attachments: patch_eos_characters
>
>
> Currently, the EOS symbols to be used by the sentence detector cannot be
> configured (at the moment, a user would have to make changes in
> opennlp.tools.sentdetect.lang.Factory
> Since it is important to use the same EOS symbols during training and during
> testing/prediction, the EOS symbols should be stored with the model's
> properties
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
