[
https://issues.apache.org/jira/browse/OPENNLP-402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13209451#comment-13209451
]
Joern Kottmann commented on OPENNLP-402:
----------------------------------------
Sorry it took me a while. I think it is still kind of complicated, because
there are so many abstract super classes and interfaces.
What do you think about replacing the CmdLineTool with AbstractCmdLineTool. We
don't really need
the CmdLineTool as interface, it could be an abstract class.
Then we do the same with BasicCmdLineTool and TypedCmdLineTool.
And it would be good if we can make it more clear what the difference between
the two is based on the name.
The javadoc comment for TypedCmdLineTool is clear, but the class name doesn't
say anything about that.
What do you think?
> CLI tools and formats refactored
> --------------------------------
>
> Key: OPENNLP-402
> URL: https://issues.apache.org/jira/browse/OPENNLP-402
> Project: OpenNLP
> Issue Type: Improvement
> Components: Command Line Interface, Formats
> Affects Versions: tools-1.5.3-incubating
> Reporter: Aliaksandr Autayeu
> Assignee: Aliaksandr Autayeu
> Labels: patch
> Fix For: tools-1.5.3-incubating
>
> Attachments: 0016-CLI-tools-and-formats-refactored.patch,
> 0017-added-direct-format-support-to-CLI-tools-and-formats.patch,
> open-nlp-cli-package.png, opennlp-cmdline-package-class-structure.png
>
>
> Proposed patch refactors CLI tools and simplifies the code by introducing
> hierarchy and removing a lot of code duplication. It also introduces better
> error and help messages, including help for formats and listing available
> formats in various tools, which are now able to work with formats directly.
> This, in turn, eliminates the need to keep converted files on disk.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
