This email is informational and I also want to pose a question. My question, first: I'm interested in merging the fix for this bug to 1.6-testing so it makes it into 1.6.3, but people will have to upgrade their surveillance-views.xml after this fix has been applied. What do you think?
http://bugzilla.opennms.org/show_bug.cgi?id=2987 A few people on the lists over time have run into problems where they misspell an attribute name in one of the XML configuration files, and as long as it is an optional attribute, there is nothing that showed that they had a bad attribute. I just committed a change to trunk to make this an error when a file is unmarshalled by one of the CastorUtils unmarshal* methods, as well as making all XML file loading use one of these methods. In the process, WillItUnmarshalTest turned up these files that had bad attributes, and they've been fixed: opennms-base-assembly/src/main/filtered/etc/examples/snmp-config.xml opennms-base-assembly/src/main/filtered/etc/examples/surveillance-views.xml opennms-base-assembly/src/main/filtered/etc/surveillance-views.xml There are likely some similarly bad config files for unit tests, and those tests will be breaking soon. :-) I'll work on fixing them Monday night if no one else beats me to them. Two future areas of work (well, after the tests are fixed): 1) Doing the same thing for marshalling calls. 2) Fixing everything that isn't UTF-8 friendly. The CastorUtils.unmarshal(Object, Reader) method is marked as deprecated because it doesn't let us read UTF-8 files. The files that are using this method now show up with deprecated warnings. You can also Eclipse's "find references" feature on the CastorUtils.unmarshal method to see who uses it, and start fixing them. You know, for those of us that have copious spare time on our hands. Ha! - djg ------------------------------------------------------------------------------ This SF.net email is sponsored by: SourcForge Community SourceForge wants to tell your story. http://p.sf.net/sfu/sf-spreadtheword _______________________________________________ Please read the OpenNMS Mailing List FAQ: http://www.opennms.org/index.php/Mailing_List_FAQ opennms-devel mailing list To *unsubscribe* or change your subscription options, see the bottom of this page: https://lists.sourceforge.net/lists/listinfo/opennms-devel
