Hi Everyone,
I’ve seen we have some Pull Requests (PR) which address multiple issues in
JIRA. As I can remember when we have to back port things or have to investigate
later changes in source code I can envision a few problems with this PRs.
- It would become hard to backport a single issue to some release if needed or
when changes needs to be investigated after a while when no-one remembers what
has been changed. To address this type of issues it would help to add
NMS-<something> / HZN-<something> in front of the commit especially in this
type of PRs. it would make it easier cause a git log search would help to
figuring out which code changes belong to which issue, see here:
https://github.com/OpenNMS/opennms/pull/1247/commits/ebe616e559872c0ccdf9e1ad10f49027aa5aed61
<https://github.com/OpenNMS/opennms/pull/1247/commits/ebe616e559872c0ccdf9e1ad10f49027aa5aed61>
In case a PR is just solving a single issue GitHub gathers all changes required
to solve this issue. It would just always require to go into GitHub closed PRs
and search for the issue number. If we want to just use git log search the
“NMS-/HZN-“ issue number in front of the commit would make that one easier as
well.
Just my thoughts
Feedback welcome
Ronny
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Please read the OpenNMS Mailing List FAQ:
http://www.opennms.org/index.php/Mailing_List_FAQ
opennms-devel mailing list
To *unsubscribe* or change your subscription options, see the bottom of this
page:
https://lists.sourceforge.net/lists/listinfo/opennms-devel
