Oups, this was meant for the other thread... On 01/31/2017 09:54 AM, Jesse White wrote: > This sounds like good practice to me. > > I don't see any problems with addressing multiple issues in a single pull > request as long as the commits are related and > properly identified. > > -Jesse > > On 01/30/2017 08:53 AM, Ronny Trommer wrote: >> Hi Guys, >> >> I would like vote for setting up Review required [1] for protected branches >> like foundation / foundation-2016 / master >> / develop? >> >> Any thoughts about this? >> >> [1] >> https://help.github.com/articles/about-required-reviews-for-pull-requests/ >> >> Greetings Ronny >> >> >> ------------------------------------------------------------------------------ >> Check out the vibrant tech community on one of the world's most >> engaging tech sites, SlashDot.org! http://sdm.link/slashdot >> >> >> _______________________________________________ >> Please read the OpenNMS Mailing List FAQ: >> http://www.opennms.org/index.php/Mailing_List_FAQ >> >> opennms-devel mailing list >> >> To *unsubscribe* or change your subscription options, see the bottom of this >> page: >> https://lists.sourceforge.net/lists/listinfo/opennms-devel >
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot _______________________________________________ Please read the OpenNMS Mailing List FAQ: http://www.opennms.org/index.php/Mailing_List_FAQ opennms-devel mailing list To *unsubscribe* or change your subscription options, see the bottom of this page: https://lists.sourceforge.net/lists/listinfo/opennms-devel
