On Fri, Jan 13, 2006 at 03:34:21PM +0100, Marcel Holtmann wrote: > Hi Eduardo, > > > I've noticed that protocol version set by openobex on all connect requests > > is 1.1 (as OBEX_VERSION is defined). But as far as I know, both the 1.2 > > and 1.3 specification documents states the protocol version as 1.0. All > > references I've found for the specifications point to the 1.2 and 1.3 > > specifications. > > > > So, to me it seems that there are no specification documents for the > > protocol version 1.1. What am I missing? > > please provide a patch for it and I like to get some comments from > others on this topic.
I couldn't write a patch for it because I wrote this message trying to find out what was wrong, exactly. If the version is really supposed to be 1.0, the fix seems to be really simple, as below. If the version was always supposed to be 0x10, I am surprised that this was unnoticed for years. --- openobex/lib/obex_main.h +++ openobex/lib/obex_main.h 2006-01-13 13:45:11.000000000 -0200 @@ -102,7 +102,7 @@ #endif /* _WIN32 */ -#define OBEX_VERSION 0x11 /* Version 1.1 */ +#define OBEX_VERSION 0x10 /* OBEX Protocol Version 1.0 */ // Note that this one is also defined in obex.h typedef void (*obex_event_t)(obex_t *handle, obex_object_t *obj, int mode, int event, int obex_cmd, int obex_rsp); -- Eduardo
pgpDueFxkEcxn.pgp
Description: PGP signature
