On Thu, Jan 19, 2006 at 02:24:15PM +0100, Marcel Holtmann wrote:
> Hi Eduardo,
> 
> > > > Otherwise, if libusb without libusb.pc is supposed to be supported,
> > > > the generation of a broken openobex.pc in this case seems to need a fix.
> > > 
> > > No. The libusb needs to be fixed, because it is their bug not to install
> > > a libusb.pc file. The only other option is not to install the openobex
> > > pkgconfig file at all.
> > 
> > If not having pkg-config support is a bug on libusb, having a broken
> > openobex.pc file seems to be a worse bug to me. But it is just my personal
> > point of view.
> 
> The openobex.pc is not broken. That's a problem of pkg-config itself,
> because in this case it misses something in the chain. The openobex.pc
> file itself is fully correct. You miss a libusb.pc on your system. And
> if this file is missing, it is a libusb bug.

When I say "broken" I mean "not working". I am not discussing "where
the bug is", otherwise we will not end the discussion. Being either
a bug or a feature, the upstream libusb doesn't support pkg-config,
and it makes the openobex.pc file not work.

> 
<snip>
> 
> Again, openobex.pc is not broken. The libusb package misses a libusb.pc
> file.

It doesn't work with the upstream libusb version. I am not discussing if
it is a libusb bug or openobex bug.

I don't see it as a libusb bug, anyway, but this question is not important
for practical reasons. Bug or not, this is present on the latest upstream
libusb version.

> 
> > Anway, I suggest the workaround below. It will affect only the pkg-config
> > support on openobex (that is broken when using the upstream libusb,
> > right now).
> > 
> > Feel free to drop it if you still disagree with my point. I won't take
> > it personally, I understood your point.  :)  But I just think that it
> > is good to keep openobex pkgconfig working when using the upstream libusb.
> 
> This workaround makes it more worse. Now people can detect openobex
> through pkg-config, but they never link with -lusb and this makes their
> application also useless.

I am not sure of that. My application wasn't linked with -lusb and worked
without libusb on Requires, and according to Alex Kanavin's last message,
we really don't need the libusb Requires on openobex.pc.

> 
> If it makes you happy, I can disable USB support at all if no libusb.pc
> is found.

I had suggested this. At least it is more consistent than accepting
a libusb without a .pc file, but ending up with an openobex.pc file
brok^H^H^H^Hthat doesn't work with the libusb version that the user
has installed.

But I think we should listen to Alex and check if the Requires:libusb
is really necessary on openobex.pc.

-- 
Eduardo

Attachment: pgpiLBKam9zeF.pgp
Description: PGP signature

Reply via email to