On Tue, Apr 25, 2006 at 04:05:52PM +0200, Marcel Holtmann wrote: > Hi Eduardo, > > > > >Do we need the slist thing to be a separate file? I think it can go into > > > >databuffer.c as static function. > > > > > > slist is used in other files too, so it's now in databuffer.c but not as > > > static. > > > > If it is used by other files, is there a reason to mix it with the > > databuffer-specific code? > > > > I would keep them in slist.c, even if the only user of the functions > > was databuffer.c. > > it was previously in netbuf.[ch] and since databuffer.[ch] supposed to > be a replacement, we keep it there. We can separate them later.
Okay, this seems to be a good reason, to me. Making one change at a time is better. -- Eduardo
pgpQmMrTWA97q.pgp
Description: PGP signature
