Am Monday 03 November 2008 05:32:35 schrieb Marcel Holtmann: > Hi guys, > > > With the recent preparation for the openobex 1.4 release and fixing > > issues we've found in the context of obexd development, I ended up > > having to change the way that the return value of obex_object_send() > > (from lib/obex_object.c) is handled within obex_client() (lib/ > > obex_client.c). > > > > It seems that obex_object_send will return 1 only if the last packet > > of the object was sent and 0 otherwise (or -1 on error). This means > > that we should be in STATE_REC and not STATE_SEND after > > obex_object_send returns 0. Without this change we were seeing two > > consecutive PUT packets without any intermediate "continue" packet > > with our obex client (obex-client from the obexd package). > > > > This change seems to work fine in our tests, but because it changes > > code which has been for a long time in openobex I decided to write > > this email to see if people see any potential issues with it and have > > a chance to test it with their code before the next official openobex > > version goes out. > > so I am ready to release openobex-1.4, but I wanna have everybody to > check that the current GIT tree is good enough and that we didn't > break something. So please give feedback.
Alex' patch 139683f9ca864a8e4fcfaf3a454c293539547903 fails to build on msvc because it doesn't like those defines like WMC_DEFAULT_OBEX_SERVER_UUID that are used as memory area later (and not just as initialiser). I am preparing a patch to fix this, moving this define to a static const array from usbobex.h to usbobex.c (it's only used once, there). Any objections? HS ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ Openobex-users mailing list Openobex-users@lists.sourceforge.net http://lists.sourceforge.net/lists/listinfo/openobex-users
