Am Tuesday 13 January 2009 11:55:21 schrieb Daehyung Jo:
> I tested OBEX authentication functionalities implemented in the newest
> obexpushd from Hendrik's repository (r136).
> Although normal file pushing functionality works fine, the OBEX
> authentication procedure had many faults and didn't work well if I use -a
> option to enable this feature.
>
> I've made a naïve patch below and confirmed that obexpushd works well with
> nokia N95 using OBEX authentication features.
> Following patches are made only to correct the OBEX authentication feature
> and need more review.
> Especially "get_pass_for_user" function seems does not read the password
> from a text file so I hard coded the password "1234" for the test :)
> Please review these patches for three files. I also commented shortly for
> the lines I added or modified.
> I hope that this might be helpful to improve openobex.
> > // script is null unless -s option is used.
> > if (data->child && script!=NULL) {
That is likely not needed as 'script' is not used in that function. And
data->child only exists if script was non-NULL.
Can you resend the diff per PM using "diff -u"? Also disable the line breaks
in your mail client or send the diff as attachment.
Why don't you simply use "svn diff >N95_auth.diff"? You are obviously worked
on the latest svn trunk revision.
I already made the "+2" changes in obex_auth.c (changing the scope of the
three variables is not necessary).
Thanks for investigating this.
HS
------------------------------------------------------------------------------
This SF.net email is sponsored by:
SourcForge Community
SourceForge wants to tell your story.
http://p.sf.net/sfu/sf-spreadtheword
_______________________________________________
Openobex-users mailing list
Openobex-users@lists.sourceforge.net
http://lists.sourceforge.net/lists/listinfo/openobex-users
