Hi Hendrik,

> >> > I also started fixing out screwed up declarations overload. Hope that
> >> > works now as expected.
> >>
> >> Let me test those changes for the Win32 build before release, please!
> >> It might needs other changes. I will tell you when I'm done with this.
> >
> > Sure. Let me know when you have verified it.
> 
> It is currently broken on Win32 (all compilers).
> I can fix it but I need a bit time to figure out the bits.
> 
> Regarding the compiler warnings (gcc), I added a patch to my updates  
> branch on gitorious.org.

I pulled that change now.

> Regarding the BtOBEX_* functions: the main problem for testing for  
> SOL_RFCOMM is that if bluetooth/bluetooth.h is not available (in  
> Linux), then that define also isn't. This would leave bdaddr_t an  
> undefined type. So if a user of OpenObex doesn't need bluetooth, that  
> makes it work for him.
> Having bluez_compat.h includes should give you that define.
> The solution may be to define (or typedef) bdaddr_t as a basic type  
> (or void*) if SOL_RFCOMM is not defined (thus adding an else case) and  
> add the function prototype unconditionally.
> Using -Werror without this makes bluetooth a hard dependency (a no-go  
> for many systems where there is no bluetooth stack).

So my take is that these functions should always be present, but when
compiled without Bluetooth support, they return an error.

The current state with having a different API depending on how it is
compiled is not a good thing anyway.

Regards

Marcel



------------------------------------------------------------------------------
Register Now for Creativity and Technology (CaT), June 3rd, NYC. CaT 
is a gathering of tech-side developers & brand creativity professionals. Meet
the minds behind Google Creative Lab, Visual Complexity, Processing, & 
iPhoneDevCamp as they present alongside digital heavyweights like Barbarian 
Group, R/GA, & Big Spaceship. http://p.sf.net/sfu/creativitycat-com 
_______________________________________________
Openobex-users mailing list
Openobex-users@lists.sourceforge.net
http://lists.sourceforge.net/lists/listinfo/openobex-users

Reply via email to