On Sun, 2010-02-21 at 16:45 +0100, Hendrik Sattler wrote:
<snip>
> > > Additionally to setting self->fd here, you should also modify
> > > obex_transport_handle_input() to no choose the special USB path when
> > > self->fd is valid.
> > 
> > Except that it doesn't work because it doesn't actually select on
> > self->fd, but on self->fd+1.
> > 
> > ret = select((int)highestfd+1, &fdset, NULL, NULL, &time);
> > 
> > I'm pretty sure that's not correct for our case.
> 
> The select call is correct. The change in obex_transport_handle_input() can 
> be 
> an additional patch.

You seem to have committed this patch despite my comments, which breaks
osso-gwobex's USB support, as well as obex_test's USB support when built
with libusb1.

The select call is correct when the ->fd is the output file descriptor,
which it isn't for USB.

So either the select call needs to be modified, or the patch needs to be
reverted.

Cheers


------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Openobex-users mailing list
Openobex-users@lists.sourceforge.net
http://lists.sourceforge.net/lists/listinfo/openobex-users

Reply via email to