Hi, On Tue, Jul 20, 2010 at 9:26 PM, Hendrik Sattler <p...@hendrik-sattler.de> wrote: > Am Montag 05 Juli 2010, 06:47:01 schrieb Hendrik Sattler: >> Am Samstag 03 Juli 2010, 14:54:55 schrieb Johan Hedberg: >> > Your tree seems to contain lots of good stuff. Any reason why you >> > haven't requested an upstream merge earlier? The changes span from early >> > march to the end of june so it seems this would have been possible a >> > long time ago. Now the change set is quite huge and will take a long >> > time to properly review. After a quick skim though I didn't find >> > anything really critical, but there seem to be plenty of white space >> > issues that'd be nice to get fixed. Also, please keep your commit >> > message width at max 72 characters so they're readable with git log on >> > 80 character terminals. >> > >> > The whitespace issues I noticed fall mainly into the following >> > categories: >> > - over 80-character line (ok if the existing code had that issue too) >> > - white space at the end of line before line terminator >> > - some empty lines not being really empty but containing tabs or spaces >> >> Those are OK to fix. > > I reorganized the patches quite a bit. Please pull from > git://gitorious.org/openobex/mainline.git for-mainline > >> > - mixed tabs and spaces for indentation >> > - more than one consecutive empty line >> > - space between function name and opening ( >> >> These are pure coding rules that are defined by personal preference. There >> are no clearly defined coding rules for the openobex code base. >> Can we stick to whatever git complains about? >> >> To enforce coding rules later, we may add vim and/or emacs instruction >> footers/headers. >> >> Note: all versions of git that I used so far complain about whitespace >> issues for files that have \r\n line endings :-( We have such files in >> OpenOBEX. > > This still applies! All changes to cmake files will cause git to complain > about > white-space errors. Some are resolved with --keep-cr but it still fails to get > this right in other places :-/
The build is broken when using autotools. -- Luiz Augusto von Dentz Computer Engineer ------------------------------------------------------------------------------ This SF.net email is sponsored by Sprint What will you do first with EVO, the first 4G phone? Visit sprint.com/first -- http://p.sf.net/sfu/sprint-com-first _______________________________________________ Openobex-users mailing list Openobex-users@lists.sourceforge.net http://lists.sourceforge.net/lists/listinfo/openobex-users
