Hi Hendrik,

On Fri, Aug 27, 2010, Hendrik Sattler wrote:
> > > The patch, together with one other is now at
> > > 
> > >   git://gitorious.org/openobex/mainline.git for-mainline
> > 
> > Thanks. It's now pushed upstream.
> 
> Thanks :-)

No problem :)

> Regarding your patch 56074c1d, though:
>   Is your editor broken? That is a really strange alignent for function
> arguments and plain ugly :-(
> Looks like "totally random but under 80chars" to me.

The rule is: at least by two tabs and as much as possible as long as the
line remains under 80 columns (and following continuation lines use the
same indentation). It's what BlueZ and other Marcel's projects use and
seems to be what the kernels doc/CodingStyle is implying in "Chapter 2:
Breaking long lines and strings" too (it's quite terse about this
though). In a way it makes sense to me too: only tabs for indentation
(which is the more general rule) and minimize the amount that the eyes
have to "scroll back" when looking at a split line.

Do you find some exceptions to this in my patch or does it still look
random to you?


Johan

------------------------------------------------------------------------------
Sell apps to millions through the Intel(R) Atom(Tm) Developer Program
Be part of this innovative community and reach millions of netbook users 
worldwide. Take advantage of special opportunities to increase revenue and 
speed time-to-market. Join now, and jumpstart your future.
http://p.sf.net/sfu/intel-atom-d2d
_______________________________________________
Openobex-users mailing list
Openobex-users@lists.sourceforge.net
http://lists.sourceforge.net/lists/listinfo/openobex-users

Reply via email to