Am Montag 08 November 2010, 07:48:14 schrieb hui li:
> hi, all, since OBEX14 has released for a long time, I`d like to port
> it on obex-data-server and openobex. What do you think about it?
> As ods is closely related to blueman and openobex, the modification
> will inevitably include blueman and openobex changes. Should I submit
> patches in a branch? Please kindly give me your any suggestion.
> Thanks.
> 
> 
> I`ve created 3 repositories in github.com:
> git://github.com/namili/blueman.git
> git://github.com/namili/obex-data-server.git
> git://github.com/namili/openobex.git
> 
> The 3 modified projects are based on some older version. They can be
> built and run well.Currently support obex over l2cap and SRM.
> I`ll port them on current version later.
> Please kindly let me know if you have any question. Thank.

Your commit 2458efe5f9267f21bfb128da73775fed963a6723 mixes the changes for 
L2CAP (OBEX_MT_* is unexplained) and SMR.

Your SMR changes introduce threads which is not an acceptable solution. I 
found your repository last week and based on that information, I have changes 
in my queue which realize this without any threading.
I don't have the spec at hand but maybe you can answer questions about it?
Is SRM only valid for PUT request and GET response? If not (which I believe is 
the case), your patch in incomplete.

The additional defines about OBEX_ACTION_* and OBEX_SRM_* do not belong to 
obex_const.h.

HS

------------------------------------------------------------------------------
The Next 800 Companies to Lead America's Growth: New Video Whitepaper
David G. Thomson, author of the best-selling book "Blueprint to a 
Billion" shares his insights and actions to help propel your 
business during the next growth cycle. Listen Now!
http://p.sf.net/sfu/SAP-dev2dev
_______________________________________________
Openobex-users mailing list
Openobex-users@lists.sourceforge.net
http://lists.sourceforge.net/lists/listinfo/openobex-users

Reply via email to