Hi Hendrik, On Mon, Dec 06, 2010, Hendrik Sattler wrote: > I have some patches in my queue. Since Johan said that I should merge more > often... ;) Comments are welcome. > > The following changes since commit 712971264d788e87200685fb4a36ab75f51d84ef: > > Fix OBEX_CancelRequest for server mode (2010-10-15 14:07:20 +0300) > > are available in the git repository at: > http://git.gitorious.org/openobex/mainline.git for-mainline > > Hendrik Sattler (13): > Make argument of buf_total_size() const > API documentation updates > Strip second argument of obex_object_setcmd() > Remove STATE_START > Handle multiple messages in RX message queue > Return correct return value for USB-1.x write timeout > Allow custom transport to insert whole packets on read() > Add support for single response mode > Reformat debug dump output > Make obex_object_send() easier to understand > Add SRM header ID definitions > Add support for SRM flags > Use fast path for rejected packets > > include/openobex/obex.h | 3 + > include/openobex/obex_const.h | 19 +++- > lib/customtrans.c | 22 ++++- > lib/databuffer.c | 19 +++- > lib/databuffer.h | 5 +- > lib/defines.h | 4 +- > lib/obex.c | 62 ++++++++--- > lib/obex.sym | 1 + > lib/obex_client.c | 169 ++++++++++++++++--------------- > lib/obex_client.h | 1 + > lib/obex_connect.c | 3 +- > lib/obex_main.c | 84 ++++++++++++++- > lib/obex_main.h | 4 + > lib/obex_object.c | 223 > ++++++++++++++++++++++++++--------------- > lib/obex_object.h | 3 +- > lib/obex_server.c | 186 +++++++++++++++++------------------ > lib/obex_server.h | 1 + > lib/obex_transport.c | 6 + > lib/usb1obex.c | 28 ++++-- > 19 files changed, 539 insertions(+), 304 deletions(-)
The patches have been pushed upstream. I didn't actually test them in practice, so I hope you've done that thoroughly ;) I also pushed a code/coding style cleanup patch on top of these, but to be fair a lot of the cleanup (maybe even most) wasn't related to issues introduced by your patches but existed in the code from before. While going through the code I noticed that it could still use quite a lot of refactoring in order to get rid of deeply nested if-statements, etc. It's by far the most common cause of it being almost impossible to adhere to the "max 79 columns" rule everywhere. Johan ------------------------------------------------------------------------------ What happens now with your Lotus Notes apps - do you make another costly upgrade, or settle for being marooned without product support? Time to move off Lotus Notes and onto the cloud with Force.com, apps are easier to build, use, and manage than apps on traditional platforms. Sign up for the Lotus Notes Migration Kit to learn more. http://p.sf.net/sfu/salesforce-d2d _______________________________________________ Openobex-users mailing list Openobex-users@lists.sourceforge.net http://lists.sourceforge.net/lists/listinfo/openobex-users
