Hi Hendrik, On Sat, Mar 12, 2011, Hendrik Sattler wrote: > I recently found that GOEP v2.0 is publically available and used that to add > a L2CAP > tranport. > Situation: > Linux: L2CAP socket available, also ERTM > FreeBSD/NetBSD: L2CAP socket available, no socket option for ERTM? > Windows: compiles but socket creation fails (Windows cannot do this, not a > coding > error) > > The FCS option needs to be set by the application, it depends on the HCI type > used > (BD/EDR or AMP) or can be added later. > I wondered if we need to also set the socket option (IMTU, ERTM) after > accepting a > client or if that automatically uses the information from the listening > socket. > > Again, the Bluez guys really should care for documentation. Try to find out > what > BT_DEFER_SETUP actually does :-( > > The following changes since commit 10b69ce470e33393b921ac4298774b8cfaa10f19: > > Fix Windows build broken by commit b807401578a6 (2011-02-22 16:38:32 -0300) > > are available in the git repository at: > git://gitorious.org/openobex/mainline.git for-mainline > > Hendrik Sattler (3): > Update install instructions > Add Bluetooth L2CAP transport > Improve obex_test > > INSTALL.txt | 10 +- > INSTALL_Win32.txt | 54 +++--- > apps/obex_test/obex_test.c | 51 +++++-- > apps/obex_test/obex_test_server.c | 2 +- > include/openobex/obex.h | 4 +- > include/openobex/obex_const.h | 3 +- > lib/CMakeLists.txt | 1 + > lib/Makefile.am | 1 + > lib/bluez_compat.h | 18 ++- > lib/btobex.c | 69 ++++++--- > lib/btobex.h | 17 ++- > lib/btobex_l2cap.c | 314 > +++++++++++++++++++++++++++++++++++++ > lib/obex.c | 23 ++- > lib/obex_main.c | 20 +++ > lib/obex_main.h | 1 + > lib/obex_transport.c | 20 ++- > lib/obex_transport.h | 2 +- > 17 files changed, 518 insertions(+), 92 deletions(-) > create mode 100644 lib/btobex_l2cap.c
The "\file .." line as well as the copyright declaration in btobex_l2cap.c seems to be wrong. Could you fix it? Besides that and some coding style issues I don't see any major problems in the patches. However, when dealing with not too big sets of patches (this is kind of a borderline case) it would actually be easier to give feedback on the particulars if you sent them with git send-email to the list instead of issuing a pull request. Johan ------------------------------------------------------------------------------ Colocation vs. Managed Hosting A question and answer guide to determining the best fit for your organization - today and in the future. http://p.sf.net/sfu/internap-sfd2d _______________________________________________ Openobex-users mailing list Openobex-users@lists.sourceforge.net http://lists.sourceforge.net/lists/listinfo/openobex-users
