On Mon, 27 Jun 2011, Hendrik Sattler wrote:

> > +#if defined(__NetBSD__) || defined(__FreeBSD__)
>
> Is it possible with the build system (autotools) to no used ifdef here
> but separate files like bt_kit_bsd.c, bt_kit_win32.c, bt_kit_linux.c
> and bt_kit_dummy.c? If not, enlarging this one file is ok, too.

it should be, you can do things like

if [ BSD ]; then
        BLUETOOTH_SRC=  bt_kit_bsd.c
fi

if [ BLUEZ ]; then
        BLUETOOTH_SRC=  bt_kit_bluez.c
fi

AC_SUBST(BLUETOOTH_SRC)

in the configure script, then just add @BLUETOOTH_SRC@ to the sources in
the Makefile.am. But, I'm not sure how much work it is worth putting into
obexftp, BlueZ does have another obex project that likely has the bigger
future..

> > +/* Various BSD systems */
> > +#elif defined(__NetBSD__) || defined(__FreeBSD__)
> > +#define COMPAT_BLUEZ
>
> Can this be used without problems? Should be use it in OpenOBEX, too?

To be honest, I don't like it and sometimes consider to just remove it
entirely. What is there under COMPAT_BLUEZ is not really well documented
or standardised in any way, and actual BlueZ/Linux compat is not really
possible to provide with just some header file additions.

iain

------------------------------------------------------------------------------
All of the data generated in your IT infrastructure is seriously valuable.
Why? It contains a definitive record of application performance, security 
threats, fraudulent activity, and more. Splunk takes this data and makes 
sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-d2d-c2
_______________________________________________
Openobex-users mailing list
Openobex-users@lists.sourceforge.net
http://lists.sourceforge.net/lists/listinfo/openobex-users

Reply via email to