This is an automated email from Gerrit.

Andreas Fritiofson ([email protected]) just uploaded a new patch set 
to Gerrit, which you can find at http://openocd.zylin.com/206

-- gerrit

commit 1b630fe628ff5cc3a841316d9171c5ad1ae32620
Author: Andreas Fritiofson <[email protected]>
Date:   Tue Nov 15 23:56:04 2011 +0100

    bitq: remove a static variable
    
    in_buff is only ever set to field->in_value and that pointer is still
    available when the parsing is restarted so it could just as well be used
    directly, removing the need for the static variable.
    
    Change-Id: I3dd7a8315ed5c5bdc3bfb74044f89492bca9816c
    Signed-off-by: Andreas Fritiofson <[email protected]>

diff --git a/src/jtag/drivers/bitq.c b/src/jtag/drivers/bitq.c
index 4e2dbc2..20aead7 100644
--- a/src/jtag/drivers/bitq.c
+++ b/src/jtag/drivers/bitq.c
@@ -44,7 +44,6 @@ static struct bitq_state bitq_in_state;
 void bitq_in_proc(void)
 {
        /* static information preserved between calls to increase performance */
-       static uint8_t*    in_buff;  /* pointer to buffer for scanned data */
        static int    in_idx;   /* index of byte being scanned */
        static uint8_t     in_mask;  /* mask of next bit to be scanned */
 
@@ -68,7 +67,6 @@ void bitq_in_proc(void)
                                                /* initialize field scanning */
                                                in_mask = 0x01;
                                                in_idx  = 0;
-                                               in_buff = field->in_value;
                                        }
 
                                        /* field scanning */
@@ -82,9 +80,9 @@ void bitq_in_proc(void)
                                                        return;
                                                }
                                                if (in_mask == 0x01)
-                                                       in_buff[in_idx] = 0;
+                                                       field->in_value[in_idx] 
= 0;
                                                if (tdo)
-                                                       in_buff[in_idx] |= 
in_mask;
+                                                       field->in_value[in_idx] 
|= in_mask;
                                                if (in_mask == 0x80)
                                                {
                                                        in_mask = 0x01;

-- 

------------------------------------------------------------------------------
RSA(R) Conference 2012
Save $700 by Nov 18
Register now
http://p.sf.net/sfu/rsa-sfdev2dev1
_______________________________________________
OpenOCD-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openocd-devel

Reply via email to