Hello, On 21.02.2012 05:55, Szymon Modzelewski wrote: > > Furthermore, the function stlink_usb_recv_v1_get_sense makes > absolutely no sense. The cdb buffer remains mostly uninitialised and > contains garbage, but it doesn't matter, because its contents are not > used (it is copied into sg_buffer, but then only the first 16 bytes of > that buffer are sent, which includes only the first byte of cdb). It > also duplicates code since it follows the exact same pattern as all > other st-link commands do. Is it even needed? There seems to be no > equivalent in texane's source. What's it supposed to do?
You should look into texane sources. The function in question is named "get_sense". The texane source send the command and then the data separately. After a short review of you patch it's really unclear to distinguish the memory fix and your rewrites. Anyway. You should split your patch into the memory fix and the rewrite thing. Regards, Mathias ------------------------------------------------------------------------------ Keep Your Developer Skills Current with LearnDevNow! The most comprehensive online learning library for Microsoft developers is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, Metro Style Apps, more. Free future releases when you subscribe now! http://p.sf.net/sfu/learndevnow-d2d _______________________________________________ OpenOCD-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openocd-devel
