> A comment to the status handler. I think if the status byte from the get > status is not zero the > command always fails. There are 3 documented cases, 0 ok, 1 command error, 2 > phase error. >
You mean documented in "USB Mass Storage Class – Bulk Only Transport", right? I'd say it's entirely possible the stlink-v1 never returns anything else than 0 in the status field, since it's known to be quirky (unless of course you know that's not the case). I've seen that jtag_libusb_bulk_read inside get_status returns 0 in case of a command error, and that causes it to fail, so there's no status code to examine in that case. Anyway, personally I'm not a big fan of dead, untested code. I'd remove the sense stuff for now, put a LOG_INFO and return ERROR_FAIL in there instead, so maybe somebody will find a test case some day (or not). ------------------------------------------------------------------------------ Keep Your Developer Skills Current with LearnDevNow! The most comprehensive online learning library for Microsoft developers is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, Metro Style Apps, more. Free future releases when you subscribe now! http://p.sf.net/sfu/learndevnow-d2d _______________________________________________ OpenOCD-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openocd-devel
