This is an automated email from Gerrit.

Alexandre Pereira da Silva (aletes....@gmail.com) just uploaded a new patch set 
to Gerrit, which you can find at http://openocd.zylin.com/483

-- gerrit

commit 94228f37f54ace3040bea1e5c2ccee895d854859
Author: Alexandre Pereira da Silva <aletes....@gmail.com>
Date:   Fri Feb 24 18:51:48 2012 -0200

    stlink: fix alignment build warning
    
    The {read,write}_mem32 interface functions was asking a 32 bits buffer but
    they don't need 32 bits alignment.
    This will change the interface to a 8 bits buffer to remove the alignment
    mismatch warning. This was causing build errors on platforms with strict
    aliasing rules.
    
    Change-Id: I338be8df5686f07a64ddb4f17c1bb494af583999
    Signed-off-by: Alexandre Pereira da Silva <aletes....@gmail.com>

diff --git a/src/jtag/drivers/stlink_usb.c b/src/jtag/drivers/stlink_usb.c
index 3cb2434..4604716 100644
--- a/src/jtag/drivers/stlink_usb.c
+++ b/src/jtag/drivers/stlink_usb.c
@@ -968,7 +968,7 @@ static int stlink_usb_write_mem8(void *handle, uint32_t 
addr, uint16_t len,
 
 /** */
 static int stlink_usb_read_mem32(void *handle, uint32_t addr, uint16_t len,
-                         uint32_t *buffer)
+                         uint8_t *buffer)
 {
        int res;
        struct stlink_usb_handle_s *h;
@@ -998,7 +998,7 @@ static int stlink_usb_read_mem32(void *handle, uint32_t 
addr, uint16_t len,
 
 /** */
 static int stlink_usb_write_mem32(void *handle, uint32_t addr, uint16_t len,
-                          const uint32_t *buffer)
+                          const uint8_t *buffer)
 {
        int res;
        struct stlink_usb_handle_s *h;
diff --git a/src/jtag/stlink/stlink_layout.h b/src/jtag/stlink/stlink_layout.h
index c0c89f5..59e6174 100644
--- a/src/jtag/stlink/stlink_layout.h
+++ b/src/jtag/stlink/stlink_layout.h
@@ -56,10 +56,10 @@ struct stlink_layout_api_s {
                            const uint8_t *buffer);
        /** */
        int (*read_mem32) (void *handle, uint32_t addr, uint16_t len,
-                          uint32_t *buffer);
+                          uint8_t *buffer);
        /** */
        int (*write_mem32) (void *handle, uint32_t addr, uint16_t len,
-                           const uint32_t *buffer);
+                           const uint8_t *buffer);
        /** */
        int (*idcode) (void *fd, uint32_t *idcode);
        /** */
diff --git a/src/target/stm32_stlink.c b/src/target/stm32_stlink.c
index 32896cc..fc97188 100644
--- a/src/target/stm32_stlink.c
+++ b/src/target/stm32_stlink.c
@@ -651,7 +651,7 @@ static int stm32_stlink_read_memory(struct target *target, 
uint32_t address,
                                        address, c, dst);
                else
                        res = stlink_if->layout->api->read_mem32(stlink_if->fd,
-                                       address, c, (uint32_t *)dst);
+                                       address, c, dst);
 
                if (res != ERROR_OK)
                        return res;
@@ -700,7 +700,7 @@ static int stm32_stlink_write_memory(struct target *target, 
uint32_t address,
                                        address, c, dst);
                else
                        res = stlink_if->layout->api->write_mem32(stlink_if->fd,
-                                       address, c, (uint32_t *)dst);
+                                       address, c, dst);
 
                if (res != ERROR_OK)
                        return res;

-- 

------------------------------------------------------------------------------
Virtualization & Cloud Management Using Capacity Planning
Cloud computing makes use of virtualization - but cloud computing 
also focuses on allowing computing to be delivered as a service.
http://www.accelacomm.com/jaw/sfnl/114/51521223/
_______________________________________________
OpenOCD-devel mailing list
OpenOCD-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openocd-devel

Reply via email to