This is an automated email from Gerrit.

Spencer Oliver (s...@spen-soft.co.uk) just uploaded a new patch set to Gerrit, 
which you can find at http://openocd.zylin.com/532

-- gerrit

commit 447cd419df44f1589551a0398255317e852a4b7d
Author: Spencer Oliver <s...@spen-soft.co.uk>
Date:   Mon Mar 19 16:38:11 2012 +0000

    transport: remove interface multiple transport warning
    
    Currently if we have multiple transport's defined we receive an warning 
similar to:
    must select a transport.
    allow transport 'jtag'
    allow transport 'swd
    
    This removes that warning and only prints this info if transport_init fails.
    
    Change-Id: I87126390f234bc2f705e1f150a0dcc110dcab151
    Signed-off-by: Spencer Oliver <s...@spen-soft.co.uk>

diff --git a/src/transport/transport.c b/src/transport/transport.c
index 59f49a9..2f35965 100644
--- a/src/transport/transport.c
+++ b/src/transport/transport.c
@@ -117,15 +117,9 @@ int allow_transports(struct command_context *ctx, const 
char **vector)
        if (!vector[1]) {
                LOG_INFO("only one transport option; autoselect '%s'", 
vector[0]);
                return transport_select(ctx, vector[0]);
-       } else {
-               /* guard against user config errors */
-               LOG_WARNING("must select a transport.");
-               while (*vector) {
-                       LOG_DEBUG("allow transport '%s'", *vector);
-                       vector++;
-               }
-               return ERROR_OK;
        }
+
+       return ERROR_OK;
 }
 
 /**
@@ -246,6 +240,13 @@ COMMAND_HANDLER(handle_transport_init)
        LOG_DEBUG("%s", __func__);
        if (!session) {
                LOG_ERROR("session's transport is not selected.");
+
+               /* no session transport configured, print transports then fail 
*/
+               const char **vector = allowed_transports;
+               while (*vector) {
+                       LOG_ERROR("allow transport '%s'", *vector);
+                       vector++;
+               }
                return ERROR_FAIL;
        }
 

-- 

------------------------------------------------------------------------------
This SF email is sponsosred by:
Try Windows Azure free for 90 days Click Here 
http://p.sf.net/sfu/sfd2d-msazure
_______________________________________________
OpenOCD-devel mailing list
OpenOCD-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openocd-devel

Reply via email to