[email protected] wrote: > +It should be noted that a negative review in Gerrit (a "-1" or "-2") may be > +discarded if both conditions are met: > +- the concerns raised in the review have been addressed (or explained), > +- reviewer does not re-examine the change in 2 weeks.
I think such a policy goes against the very purpose of peer review. There is no point in having -1 and -2 if concerns can be explained away and no confirmation is needed that concerns have actually been addressed to agreement. The libusb-1 introduction is a perfect example of how this blows up in the face of the project. It is significantly more work to fix the mess introduced by that premature submit than it would have been to address all concerns before submitting the commit. The reason that we use review is that we want our code to be high quality and thus both easy to maintain and always releaseable. Forbidding negative feedback (which is in practise what you suggest) basically short-circuits all review, and so promises that quality and maintainability will go down, and that code in git will not always be releaseable. I'm firmly in the camp of not submitting contributions in any state, so that code quality and maintainability remain high. //Peter ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ OpenOCD-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openocd-devel
