Freddie Chopin wrote: > It's not a hard rule that a negative review will ALWAYS be discarded > after ANY explanation and 2 weeks.
I think you realize that noone will ever bother to give negative review because the proposed policy makes it OK to sidestep any negative review if it considered to be inconvenient. Not the purpose of review. > It's just for situations that someone gives -2 and looses interest > in project a while after, I think this is naïve, or malicious. If someone goes through the trouble to do actual review it is highly unlikely that they will ever lose interest in that commit. They have, after all, loaded the code into their head already, so they are in a significantly better position than those who have not done any review, to discuss how the change evolves. > while the change has been improved (sometimes several times) - what > shall we do in that case - force this person to re-examine the > change? Start by trying to communicate, while at the same time understanding that most people contribute to open source projects voluntarily, in their spare time. > This is a perfect example - http://openocd.zylin.com/#/c/467/ > You gave "-2", author of the change answered and improved the patch > week after, and sice then (3 months) the change is blocked by your "-2". Can you imagine that I paged out that commit and thus didn't notice the updated patch set. Someone sent a review request for the new patch set (communicated) and so it appeared on my radar again. Good. I spent some time on it today already, but I am busy doing three-four other things, so it will probably stay open in my browser for some hours still. > SWD change is going to be drastic compared to MPSSE It doesn't have to be. It all depends on how the OpenOCD changes for supporting LibSWD are done. If they're done well then it is easy to introduce them into the tree. > which took 4 months to merge... What happened during that process exactly? If you haven't already reviewed all patch sets and read all comments then I urge you to do so before complaining about how it took too long to "merge." "merge" is what Linus does with trees from people he trusts to have only commits which have gone through thorough review already. If you've contributed something to Linux, or just watched some of the presentations about Linux development, you already know that it will take a good while to progress from initial post of a patch until Linus has merged it. OpenOCD is a much smaller project, but there's no reason not to use the same principle of review, the purpose of which is (again) to have maintainable and releaseable code in the repo. Sometimes it takes time to arrive at that, especially for significant contributions like the mpsse layer and ftdi driver. If you want to help make something happen then you are most welcome to do so. I think it is very cool that anyone can push a new patch set to an open change! I think I suggested that you do so, but you declined. //Peter ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ OpenOCD-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openocd-devel
