Andreas Fritiofson wrote:
> > Hello,
> >
> > is the telnet exit command no longer working in the latest git?
> 
> No. May have something to do with http://openocd.zylin.com/470

The commit message says:
--
This is not tested against incomming telnet
--

I don't understand why someone would submit such a commit without
at least testing that.

The change is obviously not trivial, and the commit message does
absolutely nothing to explain what is going on.

If at least one of the reviewers went through the trouble to actually
analyze what the changed code did before, and how the commit changes
that, then they could at the very least have pushed a new commit
message with an explanation.

No less than four (4!) different people looked at this commit and
thought that the commit message and the code change was good to go.

Really?


//Peter

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
OpenOCD-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openocd-devel

Reply via email to