This is an automated email from Gerrit.

Spencer Oliver ([email protected]) just uploaded a new patch set to Gerrit, 
which you can find at http://openocd.zylin.com/933

-- gerrit

commit 5b59a1479786ad6ab590549989a48cec5601b8de
Author: Spencer Oliver <[email protected]>
Date:   Fri Oct 26 12:59:29 2012 +0100

    gdb: fix broken qCRC packet handling
    
    The rtos layer was incorrectly handling a qCRC packet as a qC packet.
    Make sure we check for the qCRC packet and return unhandled so the gdb
    server gets a chance to handle it.
    
    This packet is used in the gdb compare-sections cmd.
    
    Change-Id: I21f8e5fa7225fccd13d65cf9e40186895065a7e3
    Signed-off-by: Spencer Oliver <[email protected]>

diff --git a/src/rtos/rtos.c b/src/rtos/rtos.c
index b4983c2..d4abba8 100644
--- a/src/rtos/rtos.c
+++ b/src/rtos/rtos.c
@@ -342,6 +342,10 @@ int rtos_thread_packet(struct connection *connection, char 
*packet, int packet_s
                char offsets[] = "Text=0;Data=0;Bss=0";
                gdb_put_packet(connection, offsets, sizeof(offsets)-1);
                return ERROR_OK;
+       } else if (strncmp(packet, "qCRC:", 5) == 0) {
+               /* make sure we check this before "qC" packet below
+                * otherwise it gets incorrectly handled */
+               return GDB_THREAD_PACKET_NOT_CONSUMED;
        } else if (strncmp(packet, "qC", 2) == 0) {
                if (target->rtos != NULL) {
                        char buffer[15];

-- 

------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_sfd2d_oct
_______________________________________________
OpenOCD-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openocd-devel

Reply via email to