This is an automated email from Gerrit.

Matthias Blaicher ([email protected]) just uploaded a new patch set to 
Gerrit, which you can find at http://openocd.zylin.com/959

-- gerrit

commit 94b6fa0490bd2aef1b152670e713a47537f2f0c6
Author: Matthias Blaicher <[email protected]>
Date:   Sun Nov 4 14:56:08 2012 +0100

    rtos: Fix wrong ReadyList lookup in ChibiOS
    
    We already have the address of the ReadyList provided by gdb.
    It is wrong to resolve that address a second time and it only
    works by accident.
    
    Change-Id: I82fa2360931c416290cd7f83e1883f86f90dedc2
    Signed-off-by: Matthias Blaicher <[email protected]>

diff --git a/src/rtos/ChibiOS.c b/src/rtos/ChibiOS.c
index c838b49..be5fe84 100644
--- a/src/rtos/ChibiOS.c
+++ b/src/rtos/ChibiOS.c
@@ -268,19 +268,11 @@ static int ChibiOS_update_threads(struct rtos *rtos)
        /* ChibiOS does not save the current thread count. We have to first
         * parse the double linked thread list to check for errors and the 
number of
         * threads. */
-       uint32_t rlist;
+       const uint32_t rlist = rtos->symbols[ChibiOS_VAL_rlist].address;
        uint32_t current;
        uint32_t previous;
        uint32_t older;
 
-       retval = target_read_buffer(rtos->target,
-               rtos->symbols[ChibiOS_VAL_rlist].address,
-               param->signature->ch_ptrsize,
-               (uint8_t *)&rlist);
-       if (retval != ERROR_OK) {
-               LOG_ERROR("Could not read ChibiOS ReadyList from target");
-               return retval;
-       }
        current = rlist;
        previous = rlist;
        while (1) {

-- 

------------------------------------------------------------------------------
LogMeIn Central: Instant, anywhere, Remote PC access and management.
Stay in control, update software, and manage PCs from one command center
Diagnose problems and improve visibility into emerging IT issues
Automate, monitor and manage. Do more in less time with Central
http://p.sf.net/sfu/logmein12331_d2d
_______________________________________________
OpenOCD-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openocd-devel

Reply via email to