Spencer Oliver wrote:
> I would like to get this patch series merged as soon as possible - 
> http://openocd.zylin.com/924
> 
> A few people have been testing (including TI), and the feedback is good.
> 
> Unless I hear any objections I plan to merge before the weekend.

Please hold off on that.

I know that there are changes that could use my feedback, and I will
review them, but I have had no time whatsoever for well over a week.

There is no point to gerrit if less than trivial commits were to be
pushed through without review. You should push directly to
openocd.git master if the project is supposed to "make progress"
without review.

I am sure that everyone understands (at least if they think for a bit)
that it is completely unreasonable to expect some kind of deadline
commitment from people contributing their spare time to a project.

I expect that it is in fact really really easy to understand.

Simply put: If you care about getting something reviewed then you
have to wait until it has been reviewed.

Conversely: If you don't care about review then you don't have to
wait for anything. In that case, I think you should be fair to
your peers, the presumptive reviewers, and make sure to not pretend
that you care.

It is unreasonable to shove a deadline down your peers' throats, by
saying 'I care about review only if I get it "before the weekend"' -
wouldn't you agree?

The way such a statement looks to me is that actually you don't care
about getting review, so you don't want to wait for it. If you don't
care about review then doing review is just a waste of time, and in
fact any presumptive reviewers are really being tricked.

I don't find that nice at all. It pisses me off.


//Peter

------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_nov
_______________________________________________
OpenOCD-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openocd-devel

Reply via email to