On 22/11/2012 10:51 PM, ger...@openocd.zylin.com wrote:
> This is an automated email from Gerrit.
>
> Spencer Oliver (s...@spen-soft.co.uk) just uploaded a new patch set to 
> Gerrit, which you can find at http://openocd.zylin.com/993
>
> -- gerrit
>
> commit cae17f127bfc0cbc51b9b166f10574cfdcd31033
> Author: Spencer Oliver <s...@spen-soft.co.uk>
> Date:   Thu Nov 22 11:49:52 2012 +0000
>
>      gdb: fix correct shutdown when using pipes
>      
>      50d5441e2a615fb2c44b41a777e4373901f7a2e6 commit added a regression when
>      using pipes with GDB, OpenOCD would appear to hang when exiting GDB.
>      
>      This fixes that behaviour so we shutdown correctly.
>      
>      Change-Id: I9b337c2bdd41b1966de1c7631118257afcbfa6bd
>      Signed-off-by: Spencer Oliver <s...@spen-soft.co.uk>
>
>
I've just done a functional test and it looks good, mainline with and 
without the patch behaved as described.
Nice work on the fix, this is something I've always thought was a 
massive pain when using openocd in a pipe scenario.

Tested through eclipse, windows 7 x64
cygwin / mingw compiler, clean mainline openocd compiled against 
libusbx, using a ftdi dongle.

I'm not familiar with the code to do any sort of code review however. 
And unfortunately pipe usage on my main windows machine is still so slow 
as to be unusable so I'll stick to running openocd separately.

Andrew

------------------------------------------------------------------------------
Monitor your physical, virtual and cloud infrastructure from a single
web console. Get in-depth insight into apps, servers, databases, vmware,
SAP, cloud infrastructure, etc. Download 30-day Free Trial.
Pricing starts from $795 for 25 servers or applications!
http://p.sf.net/sfu/zoho_dev2dev_nov
_______________________________________________
OpenOCD-devel mailing list
OpenOCD-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openocd-devel

Reply via email to