On 31 January 2013 10:03, Freddie Chopin <[email protected]> wrote: > Hi! > > I think there are some differences between official style guide: > http://openocd.sourceforge.net/doc/doxygen/html/stylec.html > and the checkpatch. > > One of them is that checkpatch won't allow C99 comments "// ..." while > style guide recommends them... > > There are also multiple things that checkpatch checks but are not even > mentioned in the guide (braces at the same line, no braces for > single-statements, position of '*' in relation to type, allowed length > of line is 120, spacing around operators, ...) > > Should I send a patch with update to the guide? As for the C99 comments > I think checkpatch should be changed to allow them [; >
I would imagine there are many more discrepancies, we borrowed the checkpatch script directly from the limux kernel. Tweaks to the script are added as and when we find an issue, use git log tools/scripts/checkpatch.pl to see them. Feel free to push a patch to either the checkpatch/rules to bring them in line. personally i do not like C99 comments or more than one new line, but that is for the masses to decide. Cheers Spen ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_jan _______________________________________________ OpenOCD-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openocd-devel
