On Tue, Mar 11, 2014 at 6:33 PM, Stefan Arnold <[email protected]> wrote:
> /* Compare cidr without version bits */
> if (pDetails->chipid_cidr == (pPrivate->pChip->cfg.CHIPID_CIDR &
> 0xFFFFFFE0))
>
> I had to remove the and-bitmask because all of the four devices have IDs
> with the last bit set what would not work, as described in the above
> discussion. Can somebody who is familiar with the code confirm that the
> so called "version bits" (last 5) are not used for versioning as it is
> stated?
>
I'm not familiar with the at91 chips or that code at all but in all
likelihood, the cidr should be listed in the table with the last bits
zeroed. Otherwise, of course the comparison will fail. I guess the mask is
there to avoid the need to update the table if the version changes.
Can you push the commit to Gerrit instead, as per the instructions in the
Developer's Guide?
http://openocd.sourceforge.net/doc/doxygen/html/patchguide.html
/Andreas
------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and their
applications. Written by three acclaimed leaders in the field,
this first edition is now available. Download your free book today!
http://p.sf.net/sfu/13534_NeoTech
_______________________________________________
OpenOCD-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openocd-devel
