Thanks for Paul help me to fix these errors. Remove these constants is OK. In addition, Paul's suggestion is to use macro defines instead, I will convert them to macros later on.
2014-03-31 9:15 GMT+08:00 Xiaofan Chen <[email protected]>: > On Mon, Mar 31, 2014 at 12:23 AM, Paul Fertser <[email protected]> wrote: >> On Sun, Mar 30, 2014 at 05:48:10PM +0200, Peter Stuge wrote: >>> [email protected] wrote: >>> > jtag/aice/aice_usb: remove unused constants >>> >>> Maybe there's a better way to pacify clang? It seems sad to delete >>> constants which might become useful later on? >> >> AFAICT in C language one just shouldn't use global const variables for >> this purpose and use preprocessor macros instead. I hope Hsiankai will >> convert the variables if that'd be useful and appropriate, I've added >> him to the review list already. > > An easier way seems to be commenting out the unused ones. > In that case, the author can easily uncomment them later. > > > -- > Xiaofan > > ------------------------------------------------------------------------------ > _______________________________________________ > OpenOCD-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/openocd-devel ------------------------------------------------------------------------------ _______________________________________________ OpenOCD-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openocd-devel
