On Wed, Jun 04, 2014 at 07:58:44AM +0000, ger...@openocd.zylin.com wrote:
> This is an automated email from Gerrit.
> 
> Paul Fertser (fercer...@gmail.com) just uploaded a new patch set to Gerrit, 
> which you can find at http://openocd.zylin.com/2160
> 
> -- gerrit
> 
> commit fd89352b6bff479854f29bff1af1e2fb62bc0e8c
> Author: Paul Fertser <fercer...@gmail.com>
> Date:   Wed Jun 4 11:49:58 2014 +0400
> 
>     tcl/target/fm3.cfg: use a CHIPNAME known by the flash driver
>     
>     fm3 flash driver needs to know which chip variant is used.
>     
>     This fixes "unknown fm3 variant: mb9bf500.cpu" error if the config is
>     used as is.

Hm - hard-coded flash variant names with ".cpu" appended in the C code?

Wouldn't it be better to pass some kind of flash-variant parameter to the
driver - without the .cpu, so that the flash name can be different from the
chip name, in case there are multiple chips with different names using the
same flash variant?

cu
Michael

------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and their 
applications. Written by three acclaimed leaders in the field, 
this first edition is now available. Download your free book today!
http://p.sf.net/sfu/NeoTech
_______________________________________________
OpenOCD-devel mailing list
OpenOCD-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openocd-devel

Reply via email to