It does not seem rigth to push a change to someone else's work, but I did
mock up and successfully tested a change that addresses the latest comments
on my own system to test with the other two related changes for JLink. If
you are interested I would be happy to share it or push it to gerrit. Let
me know!
I would also be happy to test whatever is proposed on Linux with LPC Link2
/ JLink configuration. Maybe I can test Win7 64 and the same hardware also.
I am interested in this change because I'd like to see both this change and
the 2297 make it into master. They are both required for myself and anyone
else using the very nice, very inexpensive JLink on LPC-Link2 adapter. It
would be so nice to have this working "out-of-the-box".
Thanks, especially to Nemui and Paul!
On Mon, Sep 29, 2014 at 12:47 PM, Spencer Oliver (Code Review) <
[email protected]> wrote:
> Spencer Oliver has posted comments on this change.
>
> Change subject: jtag/drivers/libusb1_common: avoid device reset when
> reselecting configuration
> ......................................................................
>
>
> Patch Set 2: Code-Review-1
>
> (1 comment)
>
> http://openocd.zylin.com/#/c/2288/2/src/jtag/drivers/libusb1_common.c
> File src/jtag/drivers/libusb1_common.c:
>
> Line 130: current_config == config->bConfigurationValue)
> we need to call libusb_free_config_descriptor for all code paths.
>
>
> --
> To view, visit http://openocd.zylin.com/2288
> To unsubscribe, visit http://openocd.zylin.com/settings
>
> Gerrit-MessageType: comment
> Gerrit-Change-Id: I3568ada77780a521548c450090db7173f8d0b2dd
> Gerrit-PatchSet: 2
> Gerrit-Project: openocd
> Gerrit-Branch: master
> Gerrit-Owner: Paul Fertser <[email protected]>
> Gerrit-Reviewer: Anders Oleson <[email protected]>
> Gerrit-Reviewer: Nemui Trinomius <[email protected]>
> Gerrit-Reviewer: Spencer Oliver <[email protected]>
> Gerrit-Reviewer: Xiaofan <[email protected]>
> Gerrit-Reviewer: jenkins
> Gerrit-HasComments: Yes
>
------------------------------------------------------------------------------
Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer
Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports
Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper
Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer
http://pubads.g.doubleclick.net/gampad/clk?id=154622311&iu=/4140/ostg.clktrk
_______________________________________________
OpenOCD-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openocd-devel
