This is an automated email from Gerrit.

Daniel Krebs ([email protected]) just uploaded a new patch set to Gerrit, 
which you can find at http://openocd.zylin.com/3017

-- gerrit

commit 0f9b978e1a087422015d12f981f495367542b02b
Author: daniel-k <[email protected]>
Date:   Wed Oct 14 17:30:57 2015 +0200

    rtos/mqx: Fix uninitialized parts of symbol table
    
    Memory for the symbol table was allocated by malloc but not initialized 
other
    than with the symbol name. Therefore `address` and `optional` members were
    having arbitrary values leading to every symbol being optional most of the
    time which messes up RTOS auto-detection. Memory will now be 
zero-initialized
    as in other RTOS implementations.
    
    Change-Id: I6c6e31ec1ef7e043061adf8c695b2139620e005d
    Signed-off-by: Daniel Krebs <[email protected]>

diff --git a/src/rtos/mqx.c b/src/rtos/mqx.c
index 0ba462c..272658c 100644
--- a/src/rtos/mqx.c
+++ b/src/rtos/mqx.c
@@ -544,7 +544,7 @@ static int mqx_get_thread_reg_list(
 /* API function, export list of required symbols */
 static int mqx_get_symbol_list_to_lookup(symbol_table_elem_t *symbol_list[])
 {
-       *symbol_list = malloc(sizeof(symbol_table_elem_t) * 
ARRAY_SIZE(mqx_symbol_list));
+       *symbol_list = calloc(ARRAY_SIZE(mqx_symbol_list), 
sizeof(symbol_table_elem_t));
        if (NULL == *symbol_list)
                return ERROR_FAIL;
        /* export required symbols */

-- 

------------------------------------------------------------------------------
_______________________________________________
OpenOCD-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openocd-devel

Reply via email to